lkml.org 
[lkml]   [2014]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] m68k: Remove FIXME comment in file sun3_pgalloc.h
From
On Fri, Jul 4, 2014 at 6:10 PM, Nick Krause <xerofoify@gmail.com> wrote:
> Very well then seems I should resend this patch removing the define
> line as it seems to have no use
> in this file.

Indeed. Thanks in advance!
FYI, the last user of _KERNPG_TABLE was removed in 2.5.18.

> Cheers Nick
>
> On Fri, Jul 4, 2014 at 2:19 AM, Finn Thain <fthain@telegraphics.com.au> wrote:
>>
>> On Fri, 4 Jul 2014, Nick Krause wrote:
>>
>>> What are these two lines for them another compile issue?
>>
>> I don't see why those two lines are important.
>>
>>> >> -/* FIXME - when we get this compiling */
>>> >> /* erm, now that it's compiling, what do we do with it? */
>>> >> #define _KERNPG_TABLE 0
>>
>> Presumably it is the third line that the "FIXME" refers to.
>>
>> I didn't write this code, but obviously it isn't supposed to be read as
>>
>> /* FIXME - this comment needs to be deleted */

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds


\
 
 \ /
  Last update: 2014-07-04 18:41    [W:0.063 / U:0.948 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site