Messages in this thread | | | Date | Fri, 4 Jul 2014 09:50:55 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [RFC PATCHES 0/7] Add support for showing headers in the hist browser. |
| |
Em Fri, Jul 04, 2014 at 05:53:02PM +0900, Namhyung Kim escreveu: > On Thu, 3 Jul 2014 18:48:11 -0300, Arnaldo Carvalho de Melo wrote: > > Em Thu, Jul 03, 2014 at 06:42:53PM -0300, Arnaldo Carvalho de Melo escreveu: > >> Namhyung, since you reviewed the previous patchkit, I'd like to know > >> if I can keep the acked-by and perhaps a tested-by too. This should address the > >> problems that Jiri pointed out in our private conversation.
> > Forgot to mention, it is available in this branch:
> > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git > > tmp.perf/ui/show_headers
> Thanks, you can keep my acks with fixing 7/7 changelog typo > (s/true/false/).
Ok
> I think it might even go to the perf/urgent as the cumulative children > patchset added a new children column which might confuse old users (like > you ;-) ).
Unsure about that, quite a lot of patches :-)
> But I also think it needs to fix column/header alignment > first, hmm...
Yeah, I noticed that after posting the patches, and it is even worse in 'perf top', it gets worse over time, as new symbols are added, etc. Will take a look at that.
- Arnaldo
| |