Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [RFC PATCHES 0/7] Add support for showing headers in the hist browser. | Date | Fri, 04 Jul 2014 17:53:02 +0900 |
| |
Hi Arnaldo,
On Thu, 3 Jul 2014 18:48:11 -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Jul 03, 2014 at 06:42:53PM -0300, Arnaldo Carvalho de Melo escreveu: >> Please let me know if you are ok with it and if I can have your >> Acked-by and perhaps Tested-by tags for the code I wrote. >> >> Namhyung, since you reviewed the previous patchkit, I'd like to know >> if I can keep the acked-by and perhaps a tested-by too. This should address the >> problems that Jiri pointed out in our private conversation. > > Forgot to mention, it is available in this branch: > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git > tmp.perf/ui/show_headers
Thanks, you can keep my acks with fixing 7/7 changelog typo (s/true/false/).
I think it might even go to the perf/urgent as the cumulative children patchset added a new children column which might confuse old users (like you ;-) ). But I also think it needs to fix column/header alignment first, hmm...
Thanks, Namhyung
| |