lkml.org 
[lkml]   [2014]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 8/8] perf symbol: Don't demangle parameters and such by default
    Date
    Some C++ symbols have very long name and they make column length
    longer. Most of them are about parameters including templates and we
    can ignore such info most of time IMHO.

    This patch passes DMGL_NO_OPTS by default when calling bfd_demangle().
    One can still see full symbols with -v/--verbose option.

    before:
    JS_CallFunctionValue(JSContext*, JSObject*, JS::Value, unsigned int, JS::Value*, JS::Value*)

    after:
    JS_CallFunctionValue

    Signed-off-by: Namhyung Kim <namhyung@kernel.org>
    ---
    tools/perf/util/symbol-elf.c | 7 +++++--
    tools/perf/util/symbol.h | 1 +
    2 files changed, 6 insertions(+), 2 deletions(-)

    diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c
    index d75349979e65..ec5ec1c9d9b5 100644
    --- a/tools/perf/util/symbol-elf.c
    +++ b/tools/perf/util/symbol-elf.c
    @@ -939,8 +939,11 @@ new_symbol:
    * to it...
    */
    if (symbol_conf.demangle) {
    - demangled = bfd_demangle(NULL, elf_name,
    - DMGL_PARAMS | DMGL_ANSI);
    + int demangle_flags = DMGL_NO_OPTS;
    + if (verbose)
    + demangle_flags = DMGL_PARAMS | DMGL_ANSI;
    +
    + demangled = bfd_demangle(NULL, elf_name, demangle_flags);
    if (demangled != NULL)
    elf_name = demangled;
    }
    diff --git a/tools/perf/util/symbol.h b/tools/perf/util/symbol.h
    index e7295e93cff9..c16dc16f83d5 100644
    --- a/tools/perf/util/symbol.h
    +++ b/tools/perf/util/symbol.h
    @@ -59,6 +59,7 @@ extern Elf_Scn *elf_section_by_name(Elf *elf, GElf_Ehdr *ep,
    #endif

    #ifndef DMGL_PARAMS
    +#define DMGL_NO_OPTS 0 /* For readability... */
    #define DMGL_PARAMS (1 << 0) /* Include function args */
    #define DMGL_ANSI (1 << 1) /* Include const, volatile, etc */
    #endif
    --
    2.0.0


    \
     
     \ /
      Last update: 2014-07-31 08:21    [W:3.560 / U:0.488 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site