Messages in this thread | | | Date | Thu, 31 Jul 2014 00:11:27 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH] x86, crypto: Check if gas supports CRC32 |
| |
On Wed, Jul 30, 2014 at 11:28:14PM +0200, Mathias Krause wrote: > Gah, CONFIG_AS_CRC32 gets defined as a preprocessor symbol only so > cannot be used in makefiles. So crc32c-pcl-intel-asm_64.S needs a > "#ifdef CONFIG_AS_CRC32" guard and still be compiled for CONFIG_64BIT, > as it is now. It'll be an empty object for older binutils versions not > supporting the crc32 instruction.
Yeah, that makes it all even simpler, thanks!
We're still b0rked though:
arch/x86/crypto/crct10dif-pcl-asm_64.S: Assembler messages: arch/x86/crypto/crct10dif-pcl-asm_64.S:147: Error: no such instruction: `pclmulqdq $0x0,%xmm10,%xmm0' arch/x86/crypto/crct10dif-pcl-asm_64.S:148: Error: no such instruction: `pclmulqdq $0x11,%xmm10,%xmm8' arch/x86/crypto/crct10dif-pcl-asm_64.S:149: Error: no such instruction: `pclmulqdq $0x0,%xmm10,%xmm1' ...
and need checking for more instructions. I'll play with this more tomorrow.
Good night :-)
-- Regards/Gruss, Boris.
Sent from a fat crate under my desk. Formatting is fine. --
| |