lkml.org 
[lkml]   [2014]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] brd: Fix brd_direct_access with partitions
    On 07/30/2014 06:34 PM, Matthew Wilcox wrote:
    > On Wed, Jul 30, 2014 at 05:18:47PM +0300, Boaz Harrosh wrote:
    >> When brd_direct_access() is called on a partition-bdev
    >> it would access the wrong sector. And caller would then
    >> corrupt the device's data.
    >>
    >> This is a preliminary fix, Matthew Wilcox has a patch
    >> in his DAX patchset which will define a global wrapper
    >> to bdev->bd_disk->fops->direct_access that will do the
    >> proper checks and translations before calling a driver
    >> global member. (The way it is done at the rest of the
    >> block stack)
    >
    > Uh, no, let's just focus on getting the DAX code in instead of putting
    > in interim patches that will conflict. Patch 4/22 is uncontroversial,
    > fixes this problem, has no dependencies, and is key to the rest of the DAX
    > patchset. If this problem wants to be fixed, then put 4/22 in instead.
    >

    OK, I agree, could you please push 4/22 as reply to here for
    Jens to take for 3.17 ? (together with my 1/2)

    Thanks
    Boaz



    \
     
     \ /
      Last update: 2014-07-30 18:41    [W:4.160 / U:0.268 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site