Messages in this thread | | | Date | Thu, 3 Jul 2014 10:41:09 +0200 | From | Wolfram Sang <> | Subject | Re: [PATCH v2] i2c: busses: i2c-pxa.c: Fix for possible null pointer dereferenc |
| |
Hi Rickard, hi Jingoo,
> I also trust Wolfram. He is one of the most important and active > person for Linux kernel.
Oh, thanks. I'm flattered :)
> Wolfram may mean devm_ioremap_resource(), not devm_ioremap().
Yes, you are right. Sorry for missing this detail when suggesting an example to convert to devm_*. devm_ioremap_resource should be favoured over devm_ioremap.
> 1. devm_ioremap_resource(): IS_ERR() can be used. > > dev->virtbase = devm_ioremap_resource(&adev->dev, res)); > if (IS_ERR(dev->virtbase)) {
This is correct and preferred.
BTW I don't care much about splitting up the patch as long as the commit message says that the original bug is a motivation to swicth to devm_*.
Thanks Rickard for picking up the task, and thanks Jingoo for reviewing.
Kind regards,
Wolfram
[unhandled content-type:application/pgp-signature] | |