Messages in this thread | | | From | Andy Lutomirski <> | Date | Thu, 3 Jul 2014 08:51:15 -0700 | Subject | Re: [PATCH] ix86: fix vDSO build |
| |
On Thu, Jul 3, 2014 at 8:44 AM, Jan Beulich <JBeulich@suse.com> wrote: >>>> On 03.07.14 at 17:34, <luto@amacapital.net> wrote: >> On Thu, Jul 3, 2014 at 7:35 AM, Jan Beulich <JBeulich@suse.com> wrote: >>> Relying on static functions used just once to get inlined (and >>> subsequently have dead code paths eliminated) is wrong: Compilers are >>> free to decide whether they do this, regardless of optimization level. >>> With this not happening for vdso_addr() (observed with gcc 4.1.x), an >>> unresolved reference to align_vdso_addr() causes the build to fail. >>> >>> Signed-off-by: Jan Beulich <jbeulich@suse.com> >>> Cc: Andy Lutomirski <luto@amacapital.net> >> >> Acked-by: Andy Lutomirski <luto@amacapital.net> > > Thanks (also for the other one). > >> Any chance you could send a dump of the symbol and relocation tables >> of a .so.dbg with this problem? I'm curious why checkundef.sh never >> caught it. > > vma.o is part of the kernel, not the .so.
Duh :)
--Andy
| |