Messages in this thread | | | Date | Thu, 3 Jul 2014 10:28:30 +0200 | From | Johan Hovold <> | Subject | Re: [PATCH 2/2 v5] HID: leds: move led_mode attribute to led-class devices in MSI GT683R driver |
| |
On Wed, Jul 02, 2014 at 08:37:59PM +0300, Janne Kanniainen wrote: > Move led_mode attribute from HID device to led-class devices. This will also fix race condition by using attribute-groups. > > Signed-off-by: Janne Kanniainen <janne.kanniainen@gmail.com>
Looks good now. Thanks!
Perhaps you can resend both patches as a series (call both v6) so it's easy to figure which version that is to be applied.
I also noticed that your subject line is a bit long (will end up as the commit summary). Using for example
HID: gt683r: move mode attribute to led-class devices
would make it more concise.
Oh, and your commit message lacks line breaks (around 72 cols). You could fix that as well.
Thanks again, Johan
| |