lkml.org 
[lkml]   [2014]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] microblaze: fixes includes in sigcontext.h
On Thu, 3 Jul 2014, Nicholas Krause wrote:

> diff --git a/arch/microblaze/include/uapi/asm/sigcontext.h b/arch/microblaze/include/uapi/asm/sigcontext.h
> index 55873c8..1180d9b 100644
> --- a/arch/microblaze/include/uapi/asm/sigcontext.h
> +++ b/arch/microblaze/include/uapi/asm/sigcontext.h
> @@ -9,8 +9,7 @@
> #ifndef _ASM_MICROBLAZE_SIGCONTEXT_H
> #define _ASM_MICROBLAZE_SIGCONTEXT_H
>
> -/* FIXME should be linux/ptrace.h */
> -#include <asm/ptrace.h>
> +#include <linux/ptrace.h>
>
> struct sigcontext {
> struct pt_regs regs;

Umm, does this even compile? How does sigcontext.h get the definition of
struct pt_regs? Seems like it would be better to just do a forward
declaration.


\
 
 \ /
  Last update: 2014-07-04 01:01    [W:0.051 / U:1.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site