Messages in this thread | | | Date | Thu, 3 Jul 2014 16:51:31 +0300 | From | Mikko Perttunen <> | Subject | Re: [PATCH 6/6] thermal: Add Tegra SOCTHERM thermal management driver |
| |
On 01/07/14 21:26, Stephen Warren wrote: > > Ah, so there's some manufacturing calibration process that sets some > fuse value, and the HW uses a combination of that fuse value, and some > parameters of the manufacturing process as represented by the > SENSOR_CONFIG2 register, to apply the calibration? I wonder why > SENSOR_CONFIG2 is a register not a fuse in that case, but anyway... > > Perhaps some comments or kerneldoc in the definition of struct > tegra_tsensor would be useful?
Yes, I'll add some comments.
> > Why not read THERMCTL_INTR_STATUS inside the IRQ thread. IIRC, if the > ISR wakes an IRQ thread, the interrupt remains disable until the thread > has run its course, so there's no issue deferring the register read > until the thread runs, at which point, the thread can simply loop over > all the sensors. >
If that's the case, then that's definitely a better way to do it.
| |