lkml.org 
[lkml]   [2014]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Linuxwacom-devel] [PATCH 06/15] Input - wacom: install LED/OLED sysfs files in the HID device instead of USB
    Hi Przemo,

    On Jul 03 2014 or thereabouts, Przemo Firszt wrote:
    >
    > Quoting Benjamin Tissoires <benjamin.tissoires@redhat.com>:
    >
    > >Removes one more dependency over USB, but requires some changes in
    > >the user space to find the sysfs files correctly.
    > >
    > >This patch breaks the user space. However, the number of program
    > >accessing the LEDs is quite limited and we can easily patch them
    > >to handle the new HID behavior.
    > [..]
    > Hi Bejnamin,
    > If you get the green light to break the user space we might as well think
    > about getting it in line with led/oled over bluetooth (intuos4 wireless) or
    > the other way around.

    I think it would be easier to fix the bluetooth (current hid) driver. I
    think you already implemented the bluetooth handling in gnome 3.12 and
    3.13, but having an uniform way of accessing the LEDs/OLEDs would be
    nice.

    >
    > The biggest user of led/oled functionality is gnome and there are also a few
    > small projects that would stop working after that change. I can fix i4oled
    > project easily, i4oled-gui is based on gnome handling oleds.

    I tried i4oled-gui last week or so, and patching g-s-d was enough. That
    was a good idea to rely on gnome internals for your tool :)

    >
    > Patching those 2 should be enough to fix gnome:
    > https://git.gnome.org/browse/gnome-settings-daemon/tree/plugins/wacom/gsd-wacom-led-helper.c
    > https://git.gnome.org/browse/gnome-settings-daemon/tree/plugins/wacom/gsd-wacom-oled-helper.c

    Yes, those two are sufficient enough. I had to make the patches
    (http://paste.fedoraproject.org/115318/14043949/) so I could test that nothing
    was broken. I'll submit those as soon as the fate of this conversion is
    decided.

    The current libwacom code also need a fix to handle the hid devices
    (bluetooth and this series), and I have to send it for a while now :(

    Cheers,
    Benjamin



    \
     
     \ /
      Last update: 2014-07-03 16:21    [W:5.098 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site