Messages in this thread | | | Date | Thu, 3 Jul 2014 13:49:18 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH] cpc925_edac: Use module_platform_driver() |
| |
On Mon, Jun 09, 2014 at 10:40:18PM +0800, Kefeng Wang wrote: > Move edac_op_state assignment operations to probe, then convert to > module_platform_drive() to eliminate boilerplate code, and use > cpc925_printk instead of printk. > > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> > --- > drivers/edac/cpc925_edac.c | 33 +++++++-------------------------- > 1 files changed, 7 insertions(+), 26 deletions(-) > > diff --git a/drivers/edac/cpc925_edac.c b/drivers/edac/cpc925_edac.c > index df6575f..8e3192a 100644 > --- a/drivers/edac/cpc925_edac.c > +++ b/drivers/edac/cpc925_edac.c > @@ -944,6 +944,12 @@ static int cpc925_probe(struct platform_device *pdev) > > edac_dbg(0, "%s platform device found!\n", pdev->name); > > + cpc925_printk(KERN_INFO, CPC925_EDAC_REVISION "\n"); > + cpc925_printk(KERN_INFO, "\t(c) 2008 Wind River Systems, Inc\n");
This will issue multiple times on a multi-node machine with several such bridges.
The bit converting to cpc925_printk is ok and I'll take it if you create a patch only for it.
-- Regards/Gruss, Boris.
Sent from a fat crate under my desk. Formatting is fine. --
| |