lkml.org 
[lkml]   [2014]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.15 21/37] coredump: fix the setting of PF_DUMPCORE
    Date
    3.15-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Silesh C V <svellattu@mvista.com>

    commit aed8adb7688d5744cb484226820163af31d2499a upstream.

    Commit 079148b919d0 ("coredump: factor out the setting of PF_DUMPCORE")
    cleaned up the setting of PF_DUMPCORE by removing it from all the
    linux_binfmt->core_dump() and moving it to zap_threads().But this ended
    up clearing all the previously set flags. This causes issues during
    core generation when tsk->flags is checked again (eg. for PF_USED_MATH
    to dump floating point registers). Fix this.

    Signed-off-by: Silesh C V <svellattu@mvista.com>
    Acked-by: Oleg Nesterov <oleg@redhat.com>
    Cc: Mandeep Singh Baines <msb@chromium.org>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/coredump.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/coredump.c
    +++ b/fs/coredump.c
    @@ -306,7 +306,7 @@ static int zap_threads(struct task_struc
    if (unlikely(nr < 0))
    return nr;

    - tsk->flags = PF_DUMPCORE;
    + tsk->flags |= PF_DUMPCORE;
    if (atomic_read(&mm->mm_users) == nr + 1)
    goto done;
    /*



    \
     
     \ /
      Last update: 2014-07-30 05:21    [W:2.579 / U:1.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site