lkml.org 
[lkml]   [2014]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86, efi: print debug values in Kib not MB
On Tue, 29 Jul 2014, Joe Perches wrote:

> Maybe yet another vsprintf extension?
>
> Maybe %pH<vartype> where vartype is one of [hh, h, u, ul, ull]
> with something like
> u64 t1 = (u64)*(appropriate cast)vartype;
> u64 t2 = t1;
> int index = 0;
> while ((t1 >>= 10)) {
> index++;
> t2 >>= 10;
> }
>
> to output the equivalent of
> %llu%s, t2, "bkmgtpezy"[index]
> ala dump_pagetables
>

Prarit has a good point about unnecessarily rounding the value, which is
exactly what the patch is addressing, and it wouldn't be good to be
changing the units depending on the value if anybody is using it for
anything other than reading it with their own two eyes. Since
EFI_PAGE_SIZE will always be in KB, it makes sense to export it in KB.


\
 
 \ /
  Last update: 2014-07-30 02:21    [W:0.044 / U:0.484 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site