Messages in this thread | | | Date | Tue, 29 Jul 2014 05:00:16 -0400 | From | "Chen, Gong" <> | Subject | Re: [RFC PATCH v1 13/70] x86, x2apic_cluster: _FROZEN Cleanup |
| |
On Tue, Jul 29, 2014 at 10:44:33AM +0200, Borislav Petkov wrote: > > switch (action) { > > case CPU_UP_PREPARE: > > if (!zalloc_cpumask_var(&per_cpu(cpus_in_cluster, this_cpu), > > - GFP_KERNEL)) { > > + GFP_KERNEL)) > > err = -ENOMEM; > > - } else if (!zalloc_cpumask_var(&per_cpu(ipi_mask, this_cpu), > > - GFP_KERNEL)) { > > + else if (!zalloc_cpumask_var(&per_cpu(ipi_mask, this_cpu), > > + GFP_KERNEL)) { > > free_cpumask_var(per_cpu(cpus_in_cluster, this_cpu)); > > err = -ENOMEM; > > You need to start restraining yourself and doing clean patches. Those > changes here are unrelated, please drop them. > > Go and reread Documentation/SubmittingPatches, section 3 in particular. > Copy that.
> > + if (test_and_clear_bit(CPU_TASKS_FROZEN, &action) && > > What.. why? > Sorry for that. [unhandled content-type:application/pgp-signature] | |