lkml.org 
[lkml]   [2014]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] V3 ARM: mvebu: Added dts defintion for Lenovo Iomega ix4-300d NAS
Andrew,

On Sun, Jul 27, 2014 at 03:55:09AM +0200, Andrew Lunn wrote:
> On Sat, Jul 26, 2014 at 04:48:10PM -0700, Benoit Masson wrote:
> > The Lenovo Iomega ix4-300d is a 4-Bay sata NAS with dual Gb,
> > USB2.0 & 3.0, powered by a Marvell Armada XP MV78230 dual core CPU.
> >
> > http://shop.lenovo.com/us/en/servers/network-storage/lenovoemc/ix4-300d/
> > Signed-off-by: Benoit Masson <yahoo@perenite.com>
> > ---
> > arch/arm/boot/dts/Makefile | 3 +-
> > arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts | 285 ++++++++++++++++++++++++
> > 2 files changed, 287 insertions(+), 1 deletion(-)
> > create mode 100644 arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts
> >
...
> > diff --git a/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts b/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts
> > new file mode 100644
> > index 0000000..c82a8e3
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts
...
> > + i2c@11000 {
> > + compatible = "marvell,mv64xxx-i2c";
>
> O.K, this version is good.

Is it? As Arnd mentioned against the previous version, this overrides
the default compatible property inherited from the dtsi. Since this is
also compatible with "marvell,mv78230-i2c", I think we should just
delete this line.

Benoit, this is still in V4. If Andrew agrees, I'll just remove the
line when I apply V4.

> Acked-by: Andrew Lunn <andrew@lunn.ch>

thx,

Jason.


\
 
 \ /
  Last update: 2014-07-29 01:21    [W:0.067 / U:2.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site