Messages in this thread | | | Subject | Re: [PATCH -tip/master 3/7] locking/mcs: Remove obsolete comment | From | Jason Low <> | Date | Mon, 28 Jul 2014 14:02:55 -0700 |
| |
On Mon, 2014-07-28 at 20:50 +0200, Peter Zijlstra wrote: > On Mon, Jul 28, 2014 at 10:49:35AM -0700, Jason Low wrote: > > > So if the function is inlined, perf report would show the contention > > occurring in the calling function rather than the inlined function. As > > an example, if we were to convert osq_lock() and mutex_spin_on_owner() > > to inline, perf would report all the contention from both of those > > functions occurring in just "__mutex_lock_slowpath()". > > But that's easily fixed on the tool side, right? Dwarf info (as present > in vmlinux when build with CONFIG_DEBUG_INFO) has all that.
Ok, one more reason to keep it as inline then :)
| |