lkml.org 
[lkml]   [2014]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH RFC 2/4] xen/pvhvm: Introduce xen_pvhvm_kexec_shutdown()
    On 15/07/14 14:40, Vitaly Kuznetsov wrote:
    > PVHVM guest requires special actions before kexec. Register specific
    > xen_pvhvm_kexec_shutdown() handler for machine_ops.shutdown().
    [...]
    > --- a/arch/x86/xen/enlighten.c
    > +++ b/arch/x86/xen/enlighten.c
    > @@ -1833,6 +1833,12 @@ static struct notifier_block xen_hvm_cpu_notifier = {
    > .notifier_call = xen_hvm_cpu_notify,
    > };
    >
    > +static void xen_pvhvm_kexec_shutdown(void)
    > +{
    > + xen_kexec_shutdown();

    I think it would be preferrable to have

    if (kexec_in_progress)
    xen_kexec_shutdown();

    David


    \
     
     \ /
      Last update: 2014-07-28 16:21    [W:4.811 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site