Messages in this thread Patch in this message | | | Date | Mon, 28 Jul 2014 13:10:31 +0200 | From | Pavel Machek <> | Subject | [PATCHv2] Documentation: laptops: freefall.c: Fix missing null-termination |
| |
devname is automatic variable, so it may not contain 0 at the last position.
Reported-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Signed-off-by: Pavel Machek <pavel@ucw.cz>
diff --git a/Documentation/laptops/freefall.c b/Documentation/laptops/freefall.c index aab2ff0..93a7ebf 100644 --- a/Documentation/laptops/freefall.c +++ b/Documentation/laptops/freefall.c @@ -29,7 +29,8 @@ static const char app_name[] = "FREE FALL"; static int set_unload_heads_path(char *device) { - char devname[64]; + /* static for zero termination */ + static char devname[64]; if (strlen(device) <= 5 || strncmp(device, "/dev/", 5) != 0) return -EINVAL;
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |