Messages in this thread | | | Date | Sun, 27 Jul 2014 12:09:41 +0400 | From | Vladimir Davydov <> | Subject | Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330() |
| |
On Sat, Jul 26, 2014 at 06:21:02PM +0200, Christoph Hellwig wrote: > Here's a formal one. > > James, can I get your signoff for it? > > Vladimir, can I get a reviewed-by from you (or anyone else)? > > --- > From 73b1034ab1418e2dea75ccf642bc85c728b57313 Mon Sep 17 00:00:00 2001 > From: James Bottomley <James.Bottomley@HansenPartnership.com> > Date: Sat, 26 Jul 2014 12:21:26 -0400 > Subject: scsi: use short driver name for per-driver cmd slab caches > > hostt->name might contain space, so use the ->proc_name short name instead > when creating per-driver command slabs. > > Reported-by: Vladimir Davydov <vdavydov@parallels.com> > Tested-by: Vladimir Davydov <vdavydov@parallels.com>
Actually, it was "poma <pomidorabelisima@gmail.com>", not me, who reported the issue and tested the patch. Please fix the tags.
Reviewed-by: Vladimir Davydov <vdavydov@parallels.com>
> --- > drivers/scsi/scsi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c > index 33318f5..df33060 100644 > --- a/drivers/scsi/scsi.c > +++ b/drivers/scsi/scsi.c > @@ -365,8 +365,8 @@ scsi_alloc_host_cmd_pool(struct Scsi_Host *shost) > if (!pool) > return NULL; > > - pool->cmd_name = kasprintf(GFP_KERNEL, "%s_cmd", hostt->name); > - pool->sense_name = kasprintf(GFP_KERNEL, "%s_sense", hostt->name); > + pool->cmd_name = kasprintf(GFP_KERNEL, "%s_cmd", hostt->proc_name); > + pool->sense_name = kasprintf(GFP_KERNEL, "%s_sense", hostt->proc_name); > if (!pool->cmd_name || !pool->sense_name) { > scsi_free_host_cmd_pool(pool); > return NULL; > -- > 1.9.1 >
| |