Messages in this thread Patch in this message | | | From | Rickard Strandqvist <> | Subject | [PATCH] arch: x86: ia32: ia32_aout.c: Cleaning up missing null-terminate in conjunction with strncpy | Date | Sat, 26 Jul 2014 23:50:23 +0200 |
| |
Replacing strncpy with strlcpy to avoid strings that lacks null terminate. And use the sizeof on the to string rather than the from string.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> --- arch/x86/ia32/ia32_aout.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/ia32/ia32_aout.c b/arch/x86/ia32/ia32_aout.c index d21ff89..1a5eb43 100644 --- a/arch/x86/ia32/ia32_aout.c +++ b/arch/x86/ia32/ia32_aout.c @@ -156,7 +156,7 @@ static int aout_core_dump(struct coredump_params *cprm) fs = get_fs(); set_fs(KERNEL_DS); has_dumped = 1; - strncpy(dump.u_comm, current->comm, sizeof(current->comm)); + strlcpy(dump.u_comm, current->comm, sizeof(dump.u_comm)); dump.u_ar0 = offsetof(struct user32, regs); dump.signal = cprm->siginfo->si_signo; dump_thread32(cprm->regs, &dump); -- 1.7.10.4
| |