lkml.org 
[lkml]   [2014]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.14 40/87] net: fix sparse warning in sk_dst_set()
    Date
    3.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Eric Dumazet <edumazet@google.com>

    [ Upstream commit 5925a0555bdaf0b396a84318cbc21ba085f6c0d3 ]

    sk_dst_cache has __rcu annotation, so we need a cast to avoid
    following sparse error :

    include/net/sock.h:1774:19: warning: incorrect type in initializer (different address spaces)
    include/net/sock.h:1774:19: expected struct dst_entry [noderef] <asn:4>*__ret
    include/net/sock.h:1774:19: got struct dst_entry *dst

    Signed-off-by: Eric Dumazet <edumazet@google.com>
    Reported-by: kbuild test robot <fengguang.wu@intel.com>
    Fixes: 7f502361531e ("ipv4: irq safe sk_dst_[re]set() and ipv4_sk_update_pmtu() fix")
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    include/net/sock.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/include/net/sock.h
    +++ b/include/net/sock.h
    @@ -1796,7 +1796,7 @@ sk_dst_set(struct sock *sk, struct dst_e
    struct dst_entry *old_dst;

    sk_tx_queue_clear(sk);
    - old_dst = xchg(&sk->sk_dst_cache, dst);
    + old_dst = xchg((__force struct dst_entry **)&sk->sk_dst_cache, dst);
    dst_release(old_dst);
    }




    \
     
     \ /
      Last update: 2014-07-26 22:21    [W:6.645 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site