lkml.org 
[lkml]   [2014]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] Input: add i2c/smbus driver for elan touchpad
On Fri, Jul 25, 2014 at 11:20:53AM -0700, Dmitry Torokhov wrote:
> Hi Duson,
>
> On Sat, Jul 26, 2014 at 02:05:02AM +0800, cheng wei Lin wrote:
> > Hi Dmitry,
> >
> > Sorry for late to reply you and thanks for your command
> >
> > Yes, I also agree, it looks great than my original code.
>
> Thank you for confirming.
>
> > So, should I modify this and upstream v3 patch for you?
>
> No, that is fine, I'll fix it up on my end.

Hmm, I am also looking at elan_get_x_resolution() and in case of SMB
we'll never get negative result since we are doing
"elan_convert_res(val[1] & 0x0F)". Was it intended as such, or do we
need to extend sign here via

(((char)(val[1] & 0x0F)) << 4) >> 4;

Thanks.

--
Dmitry


\
 
 \ /
  Last update: 2014-07-25 22:41    [W:0.081 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site