lkml.org 
[lkml]   [2014]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH net-next] net: filter: rename 'struct sk_filter' to 'struct bpf_prog'
    >> This follows a convention in include/uapi/linux/netfilter/*.h that
    >> likely predates the introduction of uapi. A search for "Used
    >> internally by the kernel" shows many more examples. I should not have
    >> included filter.h, however. The common behavior when using pointers
    >> to kernel-internal structures is to have a forward declaration. I suggest
    >> making that change, instead of changing to void *. This avoids having
    >> to add casts where xt_bpf_info is used in net/netfilter/xt_bpf.c:
    >
    > that will not avoid typecast.
    > Either 'void *' approach or extra 'struct sk_filter;' approach, both need
    > type casts to 'struct bpf_prog' in xt_bpf.c
    > (because of SK_RUN_FILTER macro)
    > Therefore I prefer extra 'struct sk_filter;' approach.

    I hadn't noticed that your patch makes the same change that I
    proposed. Nothing in userspace should touch that pointer, so it is
    fine to change its type to struct bpf_prog* at the same time. No need
    for typecasts.


    \
     
     \ /
      Last update: 2014-07-25 21:01    [W:7.630 / U:0.808 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site