lkml.org 
[lkml]   [2014]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers
Hi Varka,

Regarding a point you suggested.

On Fri, Jul 25, 2014 at 09:54:43AM +0530, Varka Bhadram wrote:
> On 07/25/2014 09:33 AM, Nicolin Chen wrote:
> (...)
>
> >+
> >+static const struct platform_device_id fsl_asrc_devtype[] = {
> >+ {
> >+ .name = "imx35-asrc",
> >+ .driver_data = IMX35_ASRC,
> >+ }, {
> >+ .name = "imx53-asrc",
> >+ .driver_data = IMX53_ASRC,
> >+ }, {
> >+ /* sentinel */
> >+ }
> >+};
> >+MODULE_DEVICE_TABLE(platform, fsl_asrc_devtype);
> >+
> >+static const struct of_device_id fsl_asrc_ids[] = {
> >+ {
> >+ .compatible = "fsl,imx35-asrc",
> >+ .data = &fsl_asrc_devtype[IMX35_ASRC],
> >+ }, {
> >+ .compatible = "fsl,imx53-asrc",
> >+ .data = &fsl_asrc_devtype[IMX53_ASRC],
> >+ }, {
> >+ /* sentinel */
> >+ }
> >+};
> >+MODULE_DEVICE_TABLE(of, fsl_asrc_ids);
> >+
>
> move these ids after probe/remove... every driver follows same thing...

Hmm.. fsl_asrc_ids is called in probe(), so it's probably not a good choice
to put them after probe/remove. And actually not every driver does so.
For example drivers/i2c/busses/i2c-s3c2410.c

I think it should be okay to put here if it contains data.

Thank you,
Nicolin


\
 
 \ /
  Last update: 2014-07-25 09:01    [W:0.272 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site