Messages in this thread | | | Date | Fri, 25 Jul 2014 13:49:32 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 1/3] staging: dgng: Fix Macros with complex values should be enclosed in parenthesis |
| |
On Fri, Jul 25, 2014 at 12:26:51AM +0900, Seunghun Lee wrote: > This patch fixes a checkpatch errors > "Macros with complex values should be enclosed in parenthesis" > > Signed-off-by: Seunghun Lee <waydi1@gmail.com> > --- > drivers/staging/dgnc/dgnc_driver.h | 40 ++++++++++++------------ > drivers/staging/dgnc/digi.h | 60 ++++++++++++++++++------------------ > drivers/staging/dgnc/dpacompat.h | 12 ++++---- > 3 files changed, 56 insertions(+), 56 deletions(-) > > diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/staging/dgnc/dgnc_driver.h > index fe5ea90..f7730a1 100644 > --- a/drivers/staging/dgnc/dgnc_driver.h > +++ b/drivers/staging/dgnc/dgnc_driver.h > @@ -111,32 +111,32 @@ > #endif > > #if defined TRC_TO_KMEM > -#define PRINTF_TO_KMEM(args) dgnc_tracef args > +#define PRINTF_TO_KMEM(args) do { dgnc_tracef args } while (0)
This is *so* nasty... I suspect the only reason it works is because TRC_TO_KMEM is never defined.
regards, dan carpenter
| |