Messages in this thread Patch in this message | | | From | Jingoo Han <> | Subject | Re: [PATCH v2] fb: backlight: add driver for iPAQ micro backlight | Date | Thu, 24 Jul 2014 13:28:31 +0900 |
| |
On Wednesday, July 23, 2014 6:04 PM, Linus Walleij wrote: > > This adds a driver for the backlight controlled by the microcontroller > on the Compaq iPAQ series of handheld computers: h3100, h3600 > and h3700. > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > ChangeLog v1->v2: > - Add a comment to clarify message format > - Coding format and style fixes > - Drop driver announce boilerplate > - Drop empty remove() function > --- > drivers/video/backlight/Kconfig | 9 ++++ > drivers/video/backlight/Makefile | 1 + > drivers/video/backlight/ipaq_micro_bl.c | 83 +++++++++++++++++++++++++++++++++ > 3 files changed, 93 insertions(+) > create mode 100644 drivers/video/backlight/ipaq_micro_bl.c
[.....]
> --- /dev/null > +++ b/drivers/video/backlight/ipaq_micro_bl.c > @@ -0,0 +1,83 @@ > +/* > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + * > + * iPAQ microcontroller backlight support > + * Author : Linus Walleij <linus.walleij@linaro.org> > + */ > + > +#include <linux/module.h> > +#include <linux/init.h> > +#include <linux/platform_device.h> > +#include <linux/backlight.h> > +#include <linux/mfd/ipaq-micro.h> > +#include <linux/fb.h> > +#include <linux/err.h> Would you re-order these headers alphabetically? It enhances the readability.
[.....] > +MODULE_LICENSE("GPL");
How about using "GPL v2" as below? +MODULE_LICENSE("GPL v2");
Others look good. Thanks. Acked-by: Jingoo Han <jg1.han@samsung.com>
Best regards, Jingoo Han
> +MODULE_DESCRIPTION("driver for iPAQ Atmel micro backlight"); > +MODULE_ALIAS("platform:ipaq-micro-backlight"); > -- > 1.9.3
| |