lkml.org 
[lkml]   [2014]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 07/10] Input - wacom: handle Graphire BT tablets in wacom.ko
On Thu, Jul 24, 2014 at 03:43:52PM -0400, Benjamin Tissoires wrote:
> On Jul 24 2014 or thereabouts, Dmitry Torokhov wrote:
> > Hi Benjamin,
> >
> > On Thu, Jul 24, 2014 at 02:14:02PM -0400, Benjamin Tissoires wrote:
> > > + } else if (features->type == GRAPHIRE_BT) {
> > > + /* Compute distance between mouse and tablet */
> > > + rw = 44 - (data[6] >> 2);
> > > + if (rw < 0)
> > > + rw = 0;
> > > + else if (rw > 31)
> > > + rw = 31;
> >
> > rw = clamp_val(rw, 0, 31);
> >
> > ?
>
> could be...
>
> I'll do the tests and resubmit later the v3. I'll wait a little in case
> you have other comments on the other patches :)

How about doing it incrementally - the patch is still sound as far as I
am concerned. I will wait a bit for other to chime in with comments or
acks before applying this series.

--
Dmitry


\
 
 \ /
  Last update: 2014-07-24 22:41    [W:0.079 / U:0.464 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site