lkml.org 
[lkml]   [2014]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/6] perf report: Honor column width setting
Em Thu, Jul 24, 2014 at 05:58:44PM +0200, Jiri Olsa escreveu:
> On Fri, Jul 25, 2014 at 12:41:15AM +0900, Namhyung Kim wrote:
> > On Thu, Jul 24, 2014 at 11:49 PM, Jiri Olsa <jolsa@redhat.com> wrote:
> > > On Thu, Jul 24, 2014 at 10:57:47AM -0300, Arnaldo Carvalho de Melo wrote:
> > >> Em Thu, Jul 24, 2014 at 02:57:51PM +0200, Jiri Olsa escreveu:
> > >> > struct sort_entry sort_thread = {
> > >> > .se_header = "Command: Pid",
> > >> > + .se_header_right= true,

> > >> Is this just for the header? Perhaps its more clearly named .se_right_justify?

> > > yep, it's just for header.. let's see Namhyung might have better
> > > idea how to handle this problem

> > I think it still needs to be left-aligned. So I'd rather change the

Good, I like simpler fixes :)

> > order - i.e. "Pid: Command". Is it okay for you?

> yes, jirka

Yes, its is more usual to have pid+command anyway, just run 'ps' :-)

- Arnaldo


\
 
 \ /
  Last update: 2014-07-24 21:41    [W:0.053 / U:0.116 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site