lkml.org 
[lkml]   [2014]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] gpu: drm: omapdrm: Use %pad format for values of the dma_addr_t type
From
Date
On Thu, 2014-07-24 at 21:58 +0400, matwey@sai.msu.ru wrote:
> The format change is to fix the following compilation issue:

Just a trivial note:

> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c
[]
> @@ -791,7 +791,7 @@ int omap_gem_get_paddr(struct drm_gem_object *obj,
> omap_obj->paddr = tiler_ssptr(block);
> omap_obj->block = block;
>
> - DBG("got paddr: %08x", omap_obj->paddr);
> + DBG("got paddr: %pad", &(omap_obj->paddr));

&foo->bar does not need parentheses.

Most uses in the kernel do not have them.
It seems to be ~25:1 without to with.

> @@ -985,9 +985,9 @@ void omap_gem_describe(struct drm_gem_object *obj, struct seq_file *m)
>
> off = drm_vma_node_start(&obj->vma_node);
>
> - seq_printf(m, "%08x: %2d (%2d) %08llx %08Zx (%2d) %p %4d",
> + seq_printf(m, "%08x: %2d (%2d) %08llx %pad (%2d) %p %4d",
> omap_obj->flags, obj->name, obj->refcount.refcount.counter,
> - off, omap_obj->paddr, omap_obj->paddr_cnt,
> + off, &(omap_obj->paddr), omap_obj->paddr_cnt,

etc...




\
 
 \ /
  Last update: 2014-07-24 20:41    [W:0.035 / U:0.056 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site