lkml.org 
[lkml]   [2014]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: Change kzalloc to kcalloc
On Thu, 24 Jul 2014 10:30:51 -0700
Harvey Harrison <harvey.harrison@gmail.com> wrote:

> On Thu, Jul 24, 2014 at 10:18 AM, Steven Rostedt <rostedt@goodmis.org> wrote:
> > On Thu, 24 Jul 2014 12:50:31 -0400
> > Nick Krause <xerofoify@gmail.com> wrote:
>
> >
> >> I am have this discussion with other kernel developers and just
> >> because I send out one patch as a newbie like this doesn't mean I
> >> don't known C.
> >
> > It's not just one patch, and I didn't say you don't know C. I said you
> > don't understand C enough for kernel development.
>
> And more importantly, stop guessing things are OK and selfishly asking
> others to check
> your work for you.
>
> If you have not at least _built_ the kernel with your change, and not
> _run_ it, and not made
> sure that the changed code is being _run_...you are wasting other people's time.
>

Nick,

Just to bring Harvey's email here in perspective. I mentioned in my
previous email that most of us are overworked. We don't have time to
teach you if your patches are correct or not. By saying, "I'll just
write the code and you tell me if it's correct, and test it for me" is
like telling someone "Here's a lawn mower, now go mow my lawn".

We like it if people put effort into their work and are confident
themselves that they have the right code or not. There's enough
reviewing of patches to do from people that put that effort in, that
there's no time to review patches from people that don't know if their
work or not.

Cheers,

-- Steve


\
 
 \ /
  Last update: 2014-07-24 20:22    [W:0.125 / U:37.948 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site