lkml.org 
[lkml]   [2014]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/3] staging: dgnc: Fix do not initialise statics to 0 or NULL
From
Date
Seunghun Lee schreef op vr 25-07-2014 om 00:26 [+0900]:
> This patch fixes checkpatch errors
> "do not initialise statics to 0 or NULL"
>
> Signed-off-by: Seunghun Lee <waydi1@gmail.com>
> ---
> drivers/staging/dgnc/dgnc_trace.c | 2 +-
> drivers/staging/dgnc/dgnc_tty.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_trace.c b/drivers/staging/dgnc/dgnc_trace.c
> index 2f62f2a..9be4715 100644
> --- a/drivers/staging/dgnc/dgnc_trace.c
> +++ b/drivers/staging/dgnc/dgnc_trace.c
> @@ -43,7 +43,7 @@
> static char *dgnc_trcbuf; /* the ringbuffer */
>
> #if defined(TRC_TO_KMEM)
> -static int dgnc_trcbufi = 0; /* index of the tilde at the end of */
> +static int dgnc_trcbufi; /* index of the tilde at the end of */
> #endif

I don't think TRC_TO_KMEM is defined anywhere. If that's correct, the
proper, well, fix for this checkpatch warning would be to remove all
code currently hidden behind the tests for that macro.

> #if defined(TRC_TO_KMEM)


Paul Bolle



\
 
 \ /
  Last update: 2014-07-24 19:41    [W:0.058 / U:1.144 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site