lkml.org 
[lkml]   [2014]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 00/10 linux-next] drivers/usb: remove unnecessary break after goto/return
From
Date
On Thu, 2014-07-24 at 17:46 +0200, Fabian Frederick wrote:
>
> > On 24 July 2014 at 13:37 Oliver Neukum <oneukum@suse.de> wrote:
> >
> >
> > On Thu, 2014-07-24 at 10:18 +0200, Fabian Frederick wrote:
> > > Small patchset addressing break redundancy on drivers/usb branch
> > > (suggested by Joe Perches).
> >
> > Frankly, that is not a good idea. Somebody will remove a "goto"
> > and forget to readd the "break"
>
> No problem ; checkpatch would give a warning anyway. See "Possible switch
> case/default not preceeded by break or fallthrough comment"

Generally true, but not everyone uses checkpatch.




\
 
 \ /
  Last update: 2014-07-24 18:23    [W:0.043 / U:11.812 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site