lkml.org 
[lkml]   [2014]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] perf to ctf converter
On Tue, Jul 22, 2014 at 03:31:28PM +0200, Sebastian Andrzej Siewior wrote:

SNIP

>
> So the strings look good now. I also renamed "pid" to "common_pid" because
>
> [06:37:09.885385418] (+0.017541187) sched:sched_wakeup: { cpu_id = 0 },
> { common_pid = 179, common_tid = 179, common_comm = ":179", comm = "ls",
> pid = 14068, prio = 120, success = 1, target_cpu = 5 }
>
> that thing brings its own pid & comm.
>
> And while looking at the data types and dropped that & LONG since it is
> not set for 64bit data types as I assumed. I do now consider ->size and
> the result is
>
> [06:37:09.867838634] (+0.000253941) sched:sched_stat_runtime: { cpu_id =
> 0 }, { common_pid = 14068, common_tid = 14068, common_comm = "ls", comm
> = "ls", pid = 14068, runtime = 2020750, vruntime = 76395575003 }
>
> that means vruntime is 64bit as it should and decimal might be nice.
> \o/
>
> Sebastian

hi,
I made some changes over your branch:
git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
perf/ctf_convert

following patches:
(needs to be prettyfied, but hopefuly works and ilustrate the point)
perf tools: Iterate both common_fields and fields for tracepoit
perf tools: Use sample_type for generic fields

we now add all fields available in the perf.data (via perf_event_attr:sample_type)
and then for tracepoints we add both common_types and types fields

I'm not sure we want to store made up data like symbol information,
which could be obtained from IP anyway - how does babeltrace or any
other CTF viewer do that?


---
However I'm still not convinced 100% this is the way we want
to go with this. What we do now is:
- read/parse perf.data events and convert them into ctf events

What I/we do originally wanted to do was to use CTF to describe
perf event as is defined via perf interface, so we dont need to
parse data stream, but just store it.

This would be handy/needed for CTF record support, where we _want_
to store raw data from kernel and not parse it before that.

I'll recheck and get back with issues I found with this approach.

Meanwhile I think we can continue with what we have now,
I just wanted to share the other approach with you ;-)

thanks,
jirka


\
 
 \ /
  Last update: 2014-07-24 17:21    [W:0.065 / U:59.488 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site