lkml.org 
[lkml]   [2014]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] irq: Warn when shared interrupts do not match on NO_SUSPEND
Date
On Thursday, July 24, 2014 04:15:25 PM Peter Zijlstra wrote:
> On Thu, Jul 24, 2014 at 03:46:38PM +0200, Thomas Gleixner wrote:
> > On Thu, 24 Jul 2014, Peter Zijlstra wrote:
> >
> > > Subject: irq: Warn when shared interrupts do not match on NO_SUSPEND
> > >
> > > When suspend_device_irqs() iterates all descriptors, its pointless if
> > > one has NO_SUSPEND set while another has not.
> > >
> > > Validate on request_irq() that NO_SUSPEND state maches for SHARED
> > > interrupts.
> >
> > I'm happy to take that patch, but you are aware that it is going to
> > break a few things?
> >
> > 25: .... PCI-MSI-edge aerdrv, PCIe PME
>
> Better an obvious splat than non obvious misbehaviour in my book.

And it will only break things that are already broken.

ACK for the patch.

Rafael



\
 
 \ /
  Last update: 2014-07-24 17:01    [W:0.034 / U:1.516 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site