lkml.org 
[lkml]   [2014]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH v1 14/70] x86, microcode, core: _FROZEN Cleanup
On Tue, Jul 22, 2014 at 09:58:50PM -0400, Chen, Gong wrote:
> Remove XXX_FROZEN state from x86/microcode/core.
>
> Signed-off-by: Chen, Gong <gong.chen@linux.intel.com>
> ---
> arch/x86/kernel/cpu/microcode/core.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/microcode/core.c b/arch/x86/kernel/cpu/microcode/core.c
> index dd9d619..27e47be 100644
> --- a/arch/x86/kernel/cpu/microcode/core.c
> +++ b/arch/x86/kernel/cpu/microcode/core.c
> @@ -499,6 +499,10 @@ mc_cpu_callback(struct notifier_block *nb, unsigned long action, void *hcpu)
> pr_debug("CPU%d removed\n", cpu);
> break;
>
> + case CPU_UP_CANCELED:
> + /* The CPU refused to come up during a system resume */
> + if (action & CPU_TASKS_FROZEN)
> + microcode_fini_cpu(cpu);

Missing "break". We like to add those even if it doesn't matter in this
case.

Also, add the boilerplate

"default:
break;"

while you're at it, please.

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--


\
 
 \ /
  Last update: 2014-07-24 11:41    [W:0.410 / U:31.296 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site