lkml.org 
[lkml]   [2014]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v7 03/10] x86, mpx: add macro cpu_has_mpx
    On 07/22/2014 07:35 PM, Ren, Qiaowei wrote:
    > The checking about MPX feature should be as follow:
    >
    > if (pcntxt_mask & XSTATE_EAGER) {
    > if (eagerfpu == DISABLE) {
    > pr_err("eagerfpu not present, disabling some xstate features: 0x%llx\n",
    > pcntxt_mask & XSTATE_EAGER);
    > pcntxt_mask &= ~XSTATE_EAGER;
    > } else {
    > eagerfpu = ENABLE;
    > }
    > }
    >
    > This patch was merged into kernel the ending of last year (https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e7d820a5e549b3eb6c3f9467507566565646a669 )

    Should we be doing a clear_cpu_cap(X86_FEATURE_MPX) in here?

    This isn't major, but I can't _ever_ imagine a user being able to track
    down why MPX is not working from this message. Should we spruce it up
    somehow?



    \
     
     \ /
      Last update: 2014-07-25 02:41    [W:3.159 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site