lkml.org 
[lkml]   [2014]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/2] staging: cxt1e1: Prefix ambiguous variable names with 'cxt1e1_' for clarity
On Tue, Jul 22, 2014 at 08:34:55PM -0400, Jeff Oczek wrote:
> Changed names of ambiguous sounding variable names as follows
>
> error_flag -> cxt1e1_error_flag
> max_mtu_default -> cxt1e1_max_mtu_default
> max_txdesc_used -> cxt1e1_max_txdesc_used
> max_txdesc_default -> cxt1e1_max_txdesc_default
> max_rxdesc_used -> cxt1e1_max_rxdesc_used
> max_rxdesc_default -> cxt1e1_max_rxdesc_default
>
> Since max_txdesc_used, max_rxdesc_used are module parameters, these were
> changed from global to static and the module init function assigns the values
> to the newly named global variables
>
> Signed-off-by: Jeff Oczek <jeffoczek@gmail.com>
> ---
> drivers/staging/cxt1e1/hwprobe.c | 7 ++---
> drivers/staging/cxt1e1/linux.c | 53 +++++++++++++++++++++-----------------
> drivers/staging/cxt1e1/musycc.c | 4 +--
> drivers/staging/cxt1e1/pmcc4_drv.c | 22 +++++++++-------
> drivers/staging/cxt1e1/sbeproc.c | 6 ++---
> 5 files changed, 51 insertions(+), 41 deletions(-)

This driver isn't even in my kernel tree anymore, so how can I apply it?

What kernel branch/version did you make it against? Please always work
against linux-next, or my staging-next of my staging.git kernel tree
when sending patches.

thanks,

greg k-h


\
 
 \ /
  Last update: 2014-07-24 04:02    [W:0.708 / U:1.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site