Messages in this thread | | | Date | Wed, 23 Jul 2014 16:07:37 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [PATCH] staging: Change kzalloc to kcalloc |
| |
On Wed, 23 Jul 2014, Nicholas Krause wrote:
> diff --git a/drivers/staging/android/ion/ion_dummy_driver.c b/drivers/staging/android/ion/ion_dummy_driver.c > index 3a45e79..8883432 100644 > --- a/drivers/staging/android/ion/ion_dummy_driver.c > +++ b/drivers/staging/android/ion/ion_dummy_driver.c > @@ -67,9 +67,8 @@ static int __init ion_dummy_init(void) > { > int i, err; > > idev = ion_device_create(NULL); > - heaps = kzalloc(sizeof(struct ion_heap *) * dummy_ion_pdata.nr, > - GFP_KERNEL); > + heaps = kcalloc(*dummy_ion_pdata.nr , sizeof((struct ion_heap *) *dummy_ion_pdata.nr) , GFP_KERNEL); > if (!heaps) > return -ENOMEM; >
Nack, this is not equivalent and would not even compile if tried.
| |