lkml.org 
[lkml]   [2014]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 5/5] gpio: move gpio_ensure_requested() into legacy C file
    From
    On Tue, Jul 22, 2014 at 9:17 AM, Alexandre Courbot <acourbot@nvidia.com> wrote:

    > gpio_ensure_requested() only makes sense when using the integer-based
    > GPIO API, so make sure it is called from there instead of the gpiod
    > API which we know cannot be called with a non-requested GPIO anyway.
    >
    > The uses of gpio_ensure_requested() in the gpiod API were kind of
    > out-of-place anyway, so putting them in gpio-legacy.c helps clearing the
    > code.
    >
    > Actually, considering the time this ensure_requested mechanism has been
    > around, maybe we should just turn this patch into "remove
    > gpio_ensure_requested()" if we know for sure that no user depend on it
    > anymore?
    >
    > Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>

    Patch applied.

    Make a separate patch on top to delete this thing since there
    are ZERO in-kernel users. The only place it's used in a comment
    in arch/arm/mach-ep93xx/vision_ep9307.c ....

    Yours,
    Linus Walleij


    \
     
     \ /
      Last update: 2014-07-23 18:41    [W:8.683 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site