lkml.org 
[lkml]   [2014]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH RESEND] gpio: Add support for GPIOF_ACTIVE_LOW to gpio_request_one functions
From
On Mon, Jul 21, 2014 at 8:12 PM, Guenter Roeck <linux@roeck-us.net> wrote:

> The gpio include file and the gpio documentation declare and document
> GPIOF_ACTIVE_LOW as one of the flags to be passed to gpio_request_one
> and related functions. However, the flag is not evaluated or used.
>
> This can cause problems in at least two areas: First, the same API can
> be used to auto-export pins to user space. The missing support for
> GPIOF_ACTIVE_LOW results in unexpected behavior for such auto-exported
> pins. Second, the requested gpio pin can be convered for use by
> gpiod functions with gpio_to_desc(). While gpio API functions do not
> support GPIOF_ACTIVE_LOW, gpiod functions do, which again results in
> unexpected behavior.
>
> Check the flag in gpio_request_one and set the gpio internal flag
> FLAG_ACTIVE_LOW if it is set to address those problems.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>

Patch applied after manually rebasing so it hits gpiolib-legacy.c.

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2014-07-23 18:21    [W:0.038 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site