Messages in this thread Patch in this message | | | Subject | [PATCH] serial/core: Fix too big allocation for attribute member | From | Yoshihiro YUNOMAE <> | Date | Wed, 23 Jul 2014 06:06:22 +0000 |
| |
Current code allocates too much data for tty_groups member of uart_port struct, so fix it.
Signed-off-by: Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@hitachi.com> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org> CC: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/tty/serial/serial_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c index 4af764c..8ded213 100644 --- a/drivers/tty/serial/serial_core.c +++ b/drivers/tty/serial/serial_core.c @@ -2617,7 +2617,7 @@ int uart_add_one_port(struct uart_driver *drv, struct uart_port *uport) if (uport->attr_group) num_groups++; - uport->tty_groups = kcalloc(num_groups, sizeof(**uport->tty_groups), + uport->tty_groups = kcalloc(num_groups, sizeof(*uport->tty_groups), GFP_KERNEL); if (!uport->tty_groups) { ret = -ENOMEM;
| |