lkml.org 
[lkml]   [2014]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] Added dts defintion for Lenovo ix4-300d nas
Hi Benoit,

>
> > + };
> > +
> > + serial@12000 {
> > + clocks = <&coreclk 0>;

I don't think you need the clocks property. It should be already set
in armada-xp.dtsi.

> > + adt7473@2e {
> > + compatible = "adt7473";

Please include a vendor prefix here.


> > + reg = <0x2e>;
> > + };
> > +
> > + pcf8563@51 {
> > + compatible = "pcf8563";

and a vendor prefix here.

> > + /* warning: you need both eth1 & 0 to be initialize for poweroff to shutdown otherwise it reboots */

What do you mean by initialized? Driver loaded? Interface up?

> This is a great first version

I agree with Jason, well done.

Andrew


\
 
 \ /
  Last update: 2014-07-23 17:01    [W:0.088 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site