lkml.org 
[lkml]   [2014]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V2 1/2] power: twl4030_charger: detect battery presence prior to enabling charger
    On Wed, Jul 23, 2014 at 02:24:20AM -0700, Tony Lindgren wrote:
    > * Nishanth Menon <nm@ti.com> [140528 14:48]:
    > > TWL4030's Battery Charger seems to be designed for non-hotpluggable
    > > batteries.
    > >
    > > If battery is not present in the system, BATSTS is always set with the
    > > expectation that software will take actions to move to a required safe
    > > state (could be power down or disable various charger paths).
    > >
    > > It does not seem possible even by manipulating the edge detection
    > > of the event (using BCIEDR2 register) to have a consistent hotplug
    > > handling. This seems to be the result of BATSTS interrupt generated
    > > when the thermistor of the battery pack is disconnected from the
    > > dedicated ADIN1 pin. Clearing the status just results in the status
    > > being regenerated by the monitoring ADC(MADC) and disabling the
    > > edges of event just makes hotplug no longer function. The only
    > > other option is to disable the detection of the MADC by disabling
    > > BCIMFEN4::BATSTSMCHGEN (battery presence detector) - but then, we can
    > > never again detect battery reconnection.
    > >
    > > So, detect battery presence based on precharge(which is hardware
    > > automatic state) or default main charger configuration at the time of
    > > probe and enable charger logic only if battery was present.
    > >
    > > Reported-by: Russell King <linux@arm.linux.org.uk>
    > > Tested-by: Tony Lindgren <tony@atomide.com>
    > > Signed-off-by: Nishanth Menon <nm@ti.com>
    >
    > Dmitry, can we please get this first patch merged? This is needed
    > on some omap3 platforms for DT based booting when no battery is
    > present.
    >
    > Only the second patch in this series is still being discussed AFAIK.

    applied to battery-2.6.git:

    http://git.infradead.org/battery-2.6.git/commit/61a7784efd3c89ffb6242f29bcee170dd7f55e6b

    -- Sebastian
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2014-07-23 14:41    [W:4.791 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site