Messages in this thread | | | Subject | Re: [PATCH] extcon: Add missing REGMAP_I2C/REGMAP_IRQ dependency on extcon driver | From | Krzysztof Kozlowski <> | Date | Wed, 23 Jul 2014 10:20:47 +0200 |
| |
On śro, 2014-07-23 at 10:40 +0900, Chanwoo Choi wrote: > This patch add missing REGMAP_I2C/REGMAP_IRQ dependency on extcon provider > driver to protect build break. > > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > --- > drivers/extcon/Kconfig | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig > index 6f2f472..77577db 100644 > --- a/drivers/extcon/Kconfig > +++ b/drivers/extcon/Kconfig > @@ -23,6 +23,7 @@ config EXTCON_ADC_JACK > config EXTCON_ARIZONA > tristate "Wolfson Arizona EXTCON support" > depends on MFD_ARIZONA && INPUT && SND_SOC > + select REGMAP_I2C > help > Say Y here to enable support for external accessory detection > with Wolfson Arizona devices. These are audio CODECs with > @@ -40,6 +41,7 @@ config EXTCON_MAX14577 > depends on MFD_MAX14577 > select IRQ_DOMAIN > select REGMAP_I2C > + select REGMAP_IRQ
Hi,
Is a build break possible here? I think not because this depends on MFD_MAX14577 which selects both REGMAP_I2C and REGMAP_IRQ.
This change seems not needed then.
> help > If you say yes here you get support for the MUIC device of > Maxim MAX14577/77836. The MAX14577/77836 MUIC is a USB port accessory > @@ -50,6 +52,7 @@ config EXTCON_MAX77693 > depends on MFD_MAX77693 && INPUT > select IRQ_DOMAIN > select REGMAP_I2C > + select REGMAP_IRQ
The same applies here.
> help > If you say yes here you get support for the MUIC device of > Maxim MAX77693 PMIC. The MAX77693 MUIC is a USB port accessory > @@ -66,6 +69,7 @@ config EXTCON_MAX8997 > config EXTCON_PALMAS > tristate "Palmas USB EXTCON support" > depends on MFD_PALMAS > + select REGMAP_IRQ
The same applies here.
Best regards, Krzysztof
> help > Say Y here to enable support for USB peripheral and USB host > detection by palmas usb.
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |