Messages in this thread | | | Date | Tue, 22 Jul 2014 10:38:24 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH 2/2 V2] workqueue: remove the argument @wakeup from worker_set_flags() |
| |
On Tue, Jul 22, 2014 at 01:02:00PM +0800, Lai Jiangshan wrote: > worker_set_flags() doesn't necessarily wake next worker and the @wakeup > can be removed, the caller can use the following conbination instead > when needed: > > worker_set_flags(); > if (need_more_worker(pool)) > wake_up_worker(pool); > > It reduces the machine-code and footprint for the process_one_work() > if worker_set_flags() is really inlined. > > Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Applied 1-2 to wq/for-3.17 w/ descriptions and comments updated.
Thanks.
-- tejun
| |