lkml.org 
[lkml]   [2014]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 09/19] mfd: ezx-pcap: Repair coding style errors picked up with checkpatch
From
Date
On Tue, 2014-07-22 at 12:11 +0100, Lee Jones wrote:
> This is part of an effort to clean-up the MFD subsystem.
>
> WARNING: Missing a blank line after declarations
> + u32 flags;
> + void (*callback)(void *, u16[]);

False positive from an old version of checkpatch.

The one in -next doesn't emit this as it's
simply a function pointer declaration.

> diff --git a/drivers/mfd/ezx-pcap.c b/drivers/mfd/ezx-pcap.c
[]
> @@ -25,8 +25,9 @@ struct pcap_adc_request {
> u8 bank;
> u8 ch[2];
> u32 flags;
> - void (*callback)(void *, u16[]);
> void *data;
> +
> + void (*callback)(void *, u16[]);
> };




\
 
 \ /
  Last update: 2014-07-22 17:01    [W:0.710 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site