lkml.org 
[lkml]   [2014]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: solos-pci.c: Fix me
On Sun, 20 Jul 2014 00:59:42 -0400
Nick Krause <xerofoify@gmail.com> wrote:

> Hey Chas,
> There seems to be a fix me in this file in the function, solos_bh.
> Is the default statement correct and I remove the fix me or
> does it need to be rewritten.
> Cheers Nick
>

I am afraid that I don't know enough about the solos hardware to know
if it needs to be rewritten. I gather the solos returns at least three
kinds of packets, data, status and command. If you wish to eliminate
the FIXME comment, you could just write:

@@ -850,8 +850,7 @@ static void solos_bh(unsigned long card_arg)
dev_kfree_skb_any(skb);
break;

- case PKT_COMMAND:
- default: /* FIXME: Not really, surely? */
+ default: /* PKT_COMMAND */
if (process_command(card, port, skb))
break;
spin_lock(&card->cli_queue_lock);

and be done with it since that will preserve existing behavior.


\
 
 \ /
  Last update: 2014-07-21 16:01    [W:0.755 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site