Messages in this thread | | | Date | Mon, 21 Jul 2014 15:58:57 +0300 | From | Adrian Hunter <> | Subject | Re: [PATCHv3 00/19] perf tools: Factor ordered samples queue |
| |
On 07/21/2014 03:35 PM, Jiri Olsa wrote: > On Mon, Jul 21, 2014 at 03:09:07PM +0300, Adrian Hunter wrote: > > SNIP > >>>> >>>> ...so is the 100MB limit needed at all if you have ROUND >>>> events? >>> >>> for data files captured without the ROUND events fix >> >> I am not sure it should be the default then, if it is >> not needed going forward. > > I'd be ok with not setting 100MB limit by default, just need a way > to configure it.. so without following patch: > perf tools: Limit the ordered events queue by default to 100MB
Ok then. Also it would be good to have a warning if a premature flush is forced, so that you can distinguish the cause of out-of-order messages.
| |